- 
                Notifications
    You must be signed in to change notification settings 
- Fork 11
Feat/checkbox control value accessor #1432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            13 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      1143acb
              
                feat(checkbox): add control value accessor implementation
              
              
                adisreyaj 9f3b630
              
                test(checkbox): add supporting test cases for control value accessor
              
              
                adisreyaj 0cc270c
              
                feat(checkbox): fix lint issue
              
              
                adisreyaj b489569
              
                Merge branch 'main' into feat/checkbox-control-value-accessor
              
              
                adisreyaj 9e72f75
              
                Merge branch 'main' into feat/checkbox-control-value-accessor
              
              
                adisreyaj dad1ef7
              
                Merge branch 'main' into feat/checkbox-control-value-accessor
              
              
                adisreyaj 24a94c1
              
                fix(checkbox): type coercion fix
              
              
                adisreyaj 3520581
              
                Merge branch 'main' into feat/checkbox-control-value-accessor
              
              
                adisreyaj c945ce2
              
                feat(checkbox): add change detection
              
              
                adisreyaj 377899c
              
                fix(checkbox): add checked getter
              
              
                adisreyaj 637da60
              
                fix(checkbox): add disabled getter
              
              
                adisreyaj d0d5f3e
              
                Merge branch 'main' into feat/checkbox-control-value-accessor
              
              
                adisreyaj 8d8f462
              
                fix(checkbox): fix linting issue
              
              
                adisreyaj File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need these setters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid mutating the input property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure I follow. Can you please provide more info or give example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid directly mutating the
disabledvalue which is assigned from outside via@Input()