Skip to content

Make Traces editable columns filterable for all data types that support it #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 15, 2022
Merged

Make Traces editable columns filterable for all data types that support it #1434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb9f17d
feat: configure editable column types to show quick filters if supported
jake-bassett Feb 15, 2022
147f1b5
Merge branch 'main' of github.com:hypertrace/hypertrace-ui into fix-f…
jake-bassett Feb 15, 2022
7229028
style: prettier
jake-bassett Feb 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions projects/observability/src/pages/explorer/explorer-dashboard-builder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,7 @@ export class ExplorerDashboardBuilder {
title: 'API Boundary Type',
width: '1',
visible: false,
filterable: true,
value: {
type: 'attribute-specification',
attribute: 'apiBoundaryType'
Expand All @@ -317,6 +318,7 @@ export class ExplorerDashboardBuilder {
title: 'API Discovery State',
width: '1',
visible: false,
filterable: true,
value: {
type: 'attribute-specification',
attribute: 'apiDiscoveryState'
Expand All @@ -330,6 +332,7 @@ export class ExplorerDashboardBuilder {
title: 'API ID',
width: '1',
visible: false,
filterable: true,
value: {
type: 'attribute-specification',
attribute: 'apiId'
Expand All @@ -343,6 +346,7 @@ export class ExplorerDashboardBuilder {
title: 'Entry Span ID',
width: '1',
visible: false,
filterable: true,
value: {
type: 'attribute-specification',
attribute: 'apiTraceId'
Expand All @@ -356,6 +360,7 @@ export class ExplorerDashboardBuilder {
title: 'Service ID',
width: '1',
visible: false,
filterable: true,
value: {
type: 'attribute-specification',
attribute: 'serviceId'
Expand All @@ -369,6 +374,7 @@ export class ExplorerDashboardBuilder {
title: 'Trace ID',
width: '1',
visible: false,
filterable: true,
value: {
type: 'attribute-specification',
attribute: 'traceId'
Expand All @@ -382,6 +388,7 @@ export class ExplorerDashboardBuilder {
title: 'Request URL',
width: '1',
visible: false,
filterable: true,
value: {
type: 'attribute-specification',
attribute: 'requestUrl'
Expand Down Expand Up @@ -504,6 +511,7 @@ export class ExplorerDashboardBuilder {
{
type: 'table-widget-column',
visible: false,
filterable: true,
value: {
type: 'attribute-specification',
attribute: 'traceId'
Expand Down
6 changes: 3 additions & 3 deletions ...observability/src/shared/dashboard/widgets/table/services/table-widget-columns.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,13 @@ export class TableWidgetColumnsService {
width: '1',
visible: false,
editable: true,
filterable: this.isFilterable(attribute),
filterable: this.isFilterable(attribute.type),
specification: new SpecificationBuilder().attributeSpecificationForKey(attribute.name)
};
}

private isFilterable(attribute: AttributeMetadata): boolean {
return this.filterBuilderLookupService.isBuildableType(toFilterAttributeType(attribute.type));
private isFilterable(type?: AttributeMetadataType): boolean {
return type === undefined ? false : this.filterBuilderLookupService.isBuildableType(toFilterAttributeType(type));
}

private lookupDisplayType(type: AttributeMetadataType): string {
Expand Down