Skip to content

feat: Adding date formatter #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 22, 2022
Merged

feat: Adding date formatter #1447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6cfc9c9
feat: Adding date formatter
Feb 21, 2022
698e680
Merge branch 'main' into AddingDateFormatter
palbizu Feb 21, 2022
5c394b9
feat: adding test
Feb 21, 2022
739a730
Merge branch 'AddingDateFormatter' of github.com:hypertrace/hypertrac…
Feb 21, 2022
754f88f
Merge branch 'main' into AddingDateFormatter
palbizu Feb 21, 2022
4ad5ded
Merge branch 'main' into AddingDateFormatter
palbizu Feb 22, 2022
9fed142
Merge branch 'main' into AddingDateFormatter
palbizu Feb 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion projects/common/src/utilities/formatters/date/date-formatter.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,17 @@
import { DateFormatter } from './date-formatter';
import { DateFormatMode, DateFormatter } from './date-formatter';

describe('Date formatter', () => {
const dateString = '2021-08-19T23:35:45.861Z';

test('can format a date string', () => {
expect(new DateFormatter().format(dateString)).toEqual('19 Aug 2021 11:35 PM');
});

test('can format a date string with month and year only', () => {
expect(
new DateFormatter({
mode: DateFormatMode.MonthAndYearOnly
}).format(dateString)
).toEqual('Aug 21');
});
});
3 changes: 3 additions & 0 deletions projects/common/src/utilities/formatters/date/date-formatter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ export const enum DateFormatMode {
TimeWithSeconds,
DateOnly,
MonthAndDayOnly,
MonthAndYearOnly,
DateAndTime,
DateAndTimeWithSeconds
}
Expand Down Expand Up @@ -51,6 +52,8 @@ export class DateFormatter {
return 'h:mm a';
case DateFormatMode.MonthAndDayOnly:
return 'MMM d';
case DateFormatMode.MonthAndYearOnly:
return 'MMM yy';
case DateFormatMode.DateOnly:
return 'd MMM y';
case DateFormatMode.DateAndTime:
Expand Down