Skip to content

refactor: minor style changes #1455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2022
Merged

refactor: minor style changes #1455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4d5242
refactor: minor style changes
anandtiwary Feb 24, 2022
118afd9
refactor: fixing tests
anandtiwary Feb 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion projects/components/src/collapsible-sidebar/collapsible-sidebar.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

.collapsible-sidebar {
height: inherit;
width: 220px;
position: relative;
border: 1px solid $gray-2;
border-radius: 8px;
Expand Down
6 changes: 6 additions & 0 deletions projects/components/src/filtering/filter-bar/filter-chip/filter-chip.service.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,12 @@ describe('Filter Chip service', () => {
field: attribute.name,
operator: FilterOperator.NotEquals,
userString: `${attribute.displayName} ${FilterOperator.NotEquals}`
},
{
metadata: attribute,
field: attribute.name,
operator: FilterOperator.In,
userString: `${attribute.displayName} ${FilterOperator.In}`
}
]);
});
Expand Down
8 changes: 8 additions & 0 deletions projects/components/src/filtering/filter/builder/filter-builder-lookup.service.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,14 @@ describe('Filter Builder Lookup service', () => {
value: false,
userString: 'Boolean Attribute != false',
urlString: 'booleanAttribute_neq_false'
},
{
metadata: getTestFilterAttribute(FilterAttributeType.Boolean),
field: getTestFilterAttribute(FilterAttributeType.Boolean).name,
operator: FilterOperator.In,
value: false,
userString: 'Boolean Attribute IN false',
urlString: 'booleanAttribute_in_false'
}
]);

Expand Down
2 changes: 1 addition & 1 deletion projects/components/src/filtering/filter/builder/types/boolean-filter-builder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export class BooleanFilterBuilder extends AbstractFilterBuilder<boolean> {
}

public supportedTopLevelOperators(): FilterOperator[] {
return [FilterOperator.Equals, FilterOperator.NotEquals];
return [FilterOperator.Equals, FilterOperator.NotEquals, FilterOperator.In];
}

public supportedSubpathOperators(): FilterOperator[] {
Expand Down