Skip to content

fix: in filter parser should support string array #1502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2022
Merged

fix: in filter parser should support string array #1502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b07068c
fix: in filter parser should support string array
anandtiwary Mar 24, 2022
460b651
refactor: fix tests
anandtiwary Mar 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions projects/components/src/filtering/filter/parser/filter-parser-lookup.service.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,18 @@ describe('Filter Parser Lookup service', () => {
value: 'myString'
});

expect(
spectator.service.lookup(FilterOperator.In).parseSplitFilter({
attribute: getTestFilterAttribute(FilterAttributeType.StringArray),
operator: FilterOperator.In,
rhs: 'myStr, myString'
})
).toEqual({
field: 'stringArrayAttribute',
operator: FilterOperator.In,
value: ['myStr', 'myString']
});

expect(
spectator.service.lookup(FilterOperator.In).parseSplitFilter({
attribute: getTestFilterAttribute(FilterAttributeType.String),
Expand Down
3 changes: 2 additions & 1 deletion projects/components/src/filtering/filter/parser/types/in-filter-parser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ export class InFilterParser extends AbstractFilterParser<PossibleValuesTypes> {
case FilterAttributeType.Number:
return this.parseNumberArrayValue(splitFilter.rhs);
case FilterAttributeType.Boolean: // Unsupported
case FilterAttributeType.StringArray: // Unsupported
case FilterAttributeType.StringArray:
return this.parseStringArrayValue(splitFilter.rhs);
case FilterAttributeType.Timestamp: // Unsupported
return undefined;
default:
Expand Down