Skip to content

refactor: minor tooltip and icon changes #1508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2022
Merged

refactor: minor tooltip and icon changes #1508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab74fe6
refactor: minor tooltip and icon changes
anandtiwary Mar 28, 2022
96dd30e
Merge branch 'main' into minor-changes-to-components
anandtiwary Mar 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions projects/assets-library/src/icons/icon-type.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ export const enum IconType {
Refresh = 'refresh',
Remove = 'remove',
RemoveCircle = 'remove_circle',
Restore = 'restore',
Search = 'svg:search',
Settings = 'settings',
Share = 'share',
Expand Down
2 changes: 1 addition & 1 deletion projects/components/src/select/select.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ export class SelectComponent<V> implements ControlValueAccessor, AfterContentIni
return undefined;
}

return this.items.find(item => item.value === value);
return this.items.find(item => isEqual(item.value, value));
}

public getStyleClassesForSelectItem(size: SelectSize, item: SelectOptionComponent<V>): string[] {
Expand Down
4 changes: 2 additions & 2 deletions projects/components/src/table/header/table-header-cell-renderer.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,8 @@ export class TableHeaderCellRendererComponent implements OnInit, OnChanges {
return this.indeterminateRowsSelected
? 'Some rows are selected'
: this.allRowsSelected
? 'All rows in the current page are selected'
: 'None of the rows in the current page are selected';
? 'All rows in the table are selected'
: 'None of the rows in the table are selected';
}

private buildClasses(): string[] {
Expand Down