Skip to content

fix: adding support for long and double attribute type #1519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2022
Merged

fix: adding support for long and double attribute type #1519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion projects/observability/src/pages/api-trace-detail/api-trace-detail.service.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ describe('Api TraceDetailService', () => {
name: attributeKey,
displayName: 'Duration',
units: 'ms',
type: AttributeMetadataType.Number,
type: AttributeMetadataType.Long,
scope: scope,
onlySupportsAggregation: false,
onlySupportsGrouping: false,
Expand Down
2 changes: 1 addition & 1 deletion projects/observability/src/pages/explorer/explorer-dashboard-builder.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ describe('Explorer dashboard builder', () => {
of({
name: name,
displayName: capitalize(name),
type: AttributeMetadataType.Number
type: AttributeMetadataType.Long
})
} as MetadataService,
MockService(FilterBuilderLookupService)
Expand Down
3 changes: 2 additions & 1 deletion projects/observability/src/pages/explorer/explorer-dashboard-builder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,8 @@ export class ExplorerDashboardBuilder {

private getRendererForType(type: AttributeMetadataType): string {
switch (type) {
case AttributeMetadataType.Number:
case AttributeMetadataType.Long:
case AttributeMetadataType.Double:
return CoreTableCellRendererType.Number;
case AttributeMetadataType.Timestamp:
return CoreTableCellRendererType.Timestamp;
Expand Down
2 changes: 1 addition & 1 deletion projects/observability/src/pages/explorer/explorer-service.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ describe('Explorer service', () => {
name: 'duration',
displayName: 'Duration',
units: 'ms',
type: AttributeMetadataType.Number,
type: AttributeMetadataType.Long,
scope: scope,
onlySupportsAggregation: false,
onlySupportsGrouping: false,
Expand Down
2 changes: 1 addition & 1 deletion projects/observability/src/pages/trace-detail/trace-detail.service.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ describe('TraceDetailService', () => {
name: attributeKey,
displayName: 'Latency',
units: 'ms',
type: AttributeMetadataType.Number,
type: AttributeMetadataType.Long,
scope: scope,
onlySupportsAggregation: false,
onlySupportsGrouping: false,
Expand Down
4 changes: 2 additions & 2 deletions ...ability/src/shared/components/explore-query-editor/explore-query-editor.component.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ describe('Explore query editor', () => {
scope: ObservabilityTraceType.Api,
displayName: 'First',
units: 'ms',
type: AttributeMetadataType.Number,
type: AttributeMetadataType.Long,
onlySupportsAggregation: false,
onlySupportsGrouping: false,
allowedAggregations: [MetricAggregationType.Average, MetricAggregationType.Sum],
Expand All @@ -41,7 +41,7 @@ describe('Explore query editor', () => {
scope: ObservabilityTraceType.Api,
displayName: 'Second',
units: 'ms',
type: AttributeMetadataType.Number,
type: AttributeMetadataType.Long,
onlySupportsAggregation: false,
onlySupportsGrouping: false,
allowedAggregations: [MetricAggregationType.Average, MetricAggregationType.Sum],
Expand Down
2 changes: 1 addition & 1 deletion ...c/shared/dashboard/data/graphql/api-calls-count/api-calls-count-data-source.model.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ describe('API call count data source model', () => {
{
[numCallsSpec.resultAlias()]: {
value: 100,
type: AttributeMetadataType.Number
type: AttributeMetadataType.Long
}
}
]
Expand Down
18 changes: 9 additions & 9 deletions ...ity/src/shared/dashboard/data/graphql/explore/explore-cartesian-data-source.model.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ describe('Explore cartesian data source model', () => {
name: name,
displayName: 'Duration',
units: 'ms',
type: AttributeMetadataType.Number,
type: AttributeMetadataType.Long,
scope: context,
onlySupportsAggregation: false,
onlySupportsGrouping: false,
Expand Down Expand Up @@ -99,14 +99,14 @@ describe('Explore cartesian data source model', () => {
{
'sum(foo)': {
value: 10,
type: AttributeMetadataType.Number
type: AttributeMetadataType.Long
},
[GQL_EXPLORE_RESULT_INTERVAL_KEY]: startTime
},
{
'sum(foo)': {
value: 15,
type: AttributeMetadataType.Number
type: AttributeMetadataType.Long
},
[GQL_EXPLORE_RESULT_INTERVAL_KEY]: secondIntervalTime
}
Expand Down Expand Up @@ -168,7 +168,7 @@ describe('Explore cartesian data source model', () => {
{
'sum(foo)': {
value: 10,
type: AttributeMetadataType.Number
type: AttributeMetadataType.Long
},
baz: {
value: 'first',
Expand All @@ -178,7 +178,7 @@ describe('Explore cartesian data source model', () => {
{
'sum(foo)': {
value: 15,
type: AttributeMetadataType.Number
type: AttributeMetadataType.Long
},
baz: {
value: 'second',
Expand Down Expand Up @@ -232,7 +232,7 @@ describe('Explore cartesian data source model', () => {
{
'sum(foo)': {
value: 10,
type: AttributeMetadataType.Number
type: AttributeMetadataType.Long
},
baz: {
value: 'first',
Expand All @@ -243,7 +243,7 @@ describe('Explore cartesian data source model', () => {
{
'sum(foo)': {
value: 15,
type: AttributeMetadataType.Number
type: AttributeMetadataType.Long
},
baz: {
value: 'first',
Expand All @@ -254,7 +254,7 @@ describe('Explore cartesian data source model', () => {
{
'sum(foo)': {
value: 20,
type: AttributeMetadataType.Number
type: AttributeMetadataType.Long
},
baz: {
value: 'second',
Expand All @@ -265,7 +265,7 @@ describe('Explore cartesian data source model', () => {
{
'sum(foo)': {
value: 25,
type: AttributeMetadataType.Number
type: AttributeMetadataType.Long
},
baz: {
value: 'second',
Expand Down
24 changes: 12 additions & 12 deletions projects/observability/src/shared/dashboard/data/graphql/explore/explore-result.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,21 +10,21 @@ describe('Explore result', () => {
{
'sum(foo)': {
value: 10,
type: AttributeMetadataType.Number
type: AttributeMetadataType.Long
},
[GQL_EXPLORE_RESULT_INTERVAL_KEY]: new Date(0)
},
{
'sum(foo)': {
value: 15,
type: AttributeMetadataType.Number
type: AttributeMetadataType.Long
},
[GQL_EXPLORE_RESULT_INTERVAL_KEY]: new Date(1)
},
{
'sum(foo)': {
value: 20,
type: AttributeMetadataType.Number
type: AttributeMetadataType.Long
},
[GQL_EXPLORE_RESULT_INTERVAL_KEY]: new Date(2)
}
Expand Down Expand Up @@ -53,7 +53,7 @@ describe('Explore result', () => {
{
'sum(foo)': {
value: 10,
type: AttributeMetadataType.Number
type: AttributeMetadataType.Long
},
group: {
value: 'first',
Expand All @@ -63,7 +63,7 @@ describe('Explore result', () => {
{
'sum(foo)': {
value: 15,
type: AttributeMetadataType.Number
type: AttributeMetadataType.Long
},
group: {
value: 'second',
Expand All @@ -73,7 +73,7 @@ describe('Explore result', () => {
{
'sum(foo)': {
value: 20,
type: AttributeMetadataType.Number
type: AttributeMetadataType.Long
},
group: {
value: 'third',
Expand All @@ -96,7 +96,7 @@ describe('Explore result', () => {
{
'sum(foo)': {
value: 10,
type: AttributeMetadataType.Number
type: AttributeMetadataType.Long
},
group: {
value: 'first',
Expand All @@ -106,7 +106,7 @@ describe('Explore result', () => {
{
'sum(foo)': {
value: 15,
type: AttributeMetadataType.Number
type: AttributeMetadataType.Long
},
group: {
value: '__Other',
Expand All @@ -128,7 +128,7 @@ describe('Explore result', () => {
{
'sum(foo)': {
value: 10,
type: AttributeMetadataType.Number
type: AttributeMetadataType.Long
},
group: {
value: 'first',
Expand All @@ -139,7 +139,7 @@ describe('Explore result', () => {
{
'sum(foo)': {
value: 15,
type: AttributeMetadataType.Number
type: AttributeMetadataType.Long
},
group: {
value: 'first',
Expand All @@ -150,7 +150,7 @@ describe('Explore result', () => {
{
'sum(foo)': {
value: 20,
type: AttributeMetadataType.Number
type: AttributeMetadataType.Long
},
group: {
value: 'second',
Expand All @@ -161,7 +161,7 @@ describe('Explore result', () => {
{
'sum(foo)': {
value: 25,
type: AttributeMetadataType.Number
type: AttributeMetadataType.Long
},
group: {
value: 'second',
Expand Down
18 changes: 9 additions & 9 deletions ...graphql/explorer-visualization/explorer-visualization-cartesian-data-source.model.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ describe('Explorer Visualization cartesian data source model', () => {
name: name,
displayName: 'Duration',
units: 'ms',
type: AttributeMetadataType.Number,
type: AttributeMetadataType.Long,
scope: context,
onlySupportsAggregation: false,
onlySupportsGrouping: false,
Expand Down Expand Up @@ -118,14 +118,14 @@ describe('Explorer Visualization cartesian data source model', () => {
{
'sum(foo)': {
value: 10,
type: AttributeMetadataType.Number
type: AttributeMetadataType.Long
},
[GQL_EXPLORE_RESULT_INTERVAL_KEY]: startTime
},
{
'sum(foo)': {
value: 15,
type: AttributeMetadataType.Number
type: AttributeMetadataType.Long
},
[GQL_EXPLORE_RESULT_INTERVAL_KEY]: secondIntervalTime
}
Expand Down Expand Up @@ -188,7 +188,7 @@ describe('Explorer Visualization cartesian data source model', () => {
{
'sum(foo)': {
value: 10,
type: AttributeMetadataType.Number
type: AttributeMetadataType.Long
},
baz: {
value: 'first',
Expand All @@ -198,7 +198,7 @@ describe('Explorer Visualization cartesian data source model', () => {
{
'sum(foo)': {
value: 15,
type: AttributeMetadataType.Number
type: AttributeMetadataType.Long
},
baz: {
value: 'second',
Expand Down Expand Up @@ -254,7 +254,7 @@ describe('Explorer Visualization cartesian data source model', () => {
{
'sum(foo)': {
value: 10,
type: AttributeMetadataType.Number
type: AttributeMetadataType.Long
},
baz: {
value: 'first',
Expand All @@ -265,7 +265,7 @@ describe('Explorer Visualization cartesian data source model', () => {
{
'sum(foo)': {
value: 15,
type: AttributeMetadataType.Number
type: AttributeMetadataType.Long
},
baz: {
value: 'first',
Expand All @@ -276,7 +276,7 @@ describe('Explorer Visualization cartesian data source model', () => {
{
'sum(foo)': {
value: 20,
type: AttributeMetadataType.Number
type: AttributeMetadataType.Long
},
baz: {
value: 'second',
Expand All @@ -287,7 +287,7 @@ describe('Explorer Visualization cartesian data source model', () => {
{
'sum(foo)': {
value: 25,
type: AttributeMetadataType.Number
type: AttributeMetadataType.Long
},
baz: {
value: 'second',
Expand Down
2 changes: 1 addition & 1 deletion ...ed/dashboard/data/graphql/metric-aggregation/metric-aggregation-data-source.model.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ describe('Metric aggregation data source model', () => {
{
[callCountSpec.resultAlias()]: {
value: 10,
type: AttributeMetadataType.Number
type: AttributeMetadataType.Long
}
}
]
Expand Down
4 changes: 2 additions & 2 deletions ...ility/src/shared/dashboard/data/graphql/trace/donut/trace-donut-data-source.model.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ describe('Donut data source model', () => {
{
'sum(foo)': {
value: 10,
type: AttributeMetadataType.Number
type: AttributeMetadataType.Long
},
bar: {
value: 'first',
Expand All @@ -106,7 +106,7 @@ describe('Donut data source model', () => {
{
'sum(foo)': {
value: 15,
type: AttributeMetadataType.Number
type: AttributeMetadataType.Long
},
bar: {
value: 'second',
Expand Down
6 changes: 4 additions & 2 deletions ...observability/src/shared/dashboard/widgets/table/services/table-widget-columns.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,8 @@ export class TableWidgetColumnsService {

private lookupDisplayType(type: AttributeMetadataType): string {
switch (type) {
case AttributeMetadataType.Number:
case AttributeMetadataType.Long:
case AttributeMetadataType.Double:
return CoreTableCellRendererType.Number;
case AttributeMetadataType.Timestamp:
return CoreTableCellRendererType.Timestamp;
Expand All @@ -77,7 +78,8 @@ export class TableWidgetColumnsService {

private lookupAlignment(type: AttributeMetadataType): TableCellAlignmentType {
switch (type) {
case AttributeMetadataType.Number:
case AttributeMetadataType.Long:
case AttributeMetadataType.Double:
case AttributeMetadataType.Timestamp:
return TableCellAlignmentType.Right;
default:
Expand Down
Loading