Skip to content

Conversation

@cseas
Copy link
Contributor

@cseas cseas commented Jul 26, 2022

Description

Fixes #1641

Testing

  • Add some filters to the Explorer screen search
  • Expand one of the results
  • Add one of the attributes to the search using the filter button
  • Previous filters should be kept intact and the new attribute filter should be added to the search bar

Screenshot_2022-07-26_at_9_31_09_AM

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Bugfix, N/A

@cseas cseas requested a review from a team as a code owner July 26, 2022 04:05
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #1766 (7fd5b34) into main (2e37eb4) will decrease coverage by 0.00%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##             main    #1766      +/-   ##
==========================================
- Coverage   83.43%   83.43%   -0.01%     
==========================================
  Files         883      883              
  Lines       19178    19183       +5     
  Branches     2683     2685       +2     
==========================================
+ Hits        16002    16006       +4     
  Misses       3038     3038              
- Partials      138      139       +1     
Impacted Files Coverage Δ
...servability/src/pages/explorer/explorer-service.ts 95.23% <87.50%> (-4.77%) ⬇️
...nts/span-detail/tags/span-tags-detail.component.ts 95.45% <100.00%> (+0.45%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: UI filter buttons in expanded view of Explorer results remove previously chosen filters

1 participant