fix: fix table scrolling and loading issues #309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Load Async is built to show loaders for content rendered inside it. We are using it in table as a placeholder where the loader wrapper stays after the cdk table has loaded all data. This creates lots of layout issues especially when using with flex container - Introducing a new hide property in table loading state to remove the loader wrapper once loading is completed. In case of error or no data, the loader will automatically take the entire space. - removing host properties as it interferes with flex properties for parent container - adding flex grow to explorer table
Codecov Report
@@ Coverage Diff @@
## main #309 +/- ##
=======================================
Coverage 86.14% 86.14%
=======================================
Files 716 716
Lines 14598 14598
Branches 1814 1863 +49
=======================================
Hits 12575 12575
- Misses 1991 1993 +2
+ Partials 32 30 -2
Continue to review full report at Codecov.
|
aaron-steinfeld
approved these changes
Oct 30, 2020
| import { TableColumnConfigExtended, TableService } from './table.service'; | ||
|
|
||
| // tslint:disable max-file-line-count | ||
| // tslint:disable: template-cyclomatic-complexity component-max-inline-declarations max-file-line-count |
jake-bassett
approved these changes
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load Async is built to show loaders for content rendered inside it.
We are using it in table as a placeholder where the loader wrapper
stays after the cdk table has loaded all data. This creates lots of
layout issues especially when using with flex container
Introducing a new hide property in table loading state to remove the
loader wrapper once loading is completed. In case of error or no data,
the loader will automatically take the entire space.
removing host properties as it interferes with flex properties for parent container
adding flex grow to explorer table