-
Notifications
You must be signed in to change notification settings - Fork 11
fix: updating table source #326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
renderer: rendererConstructor, | ||
parser: new parserConstructor(this.rootInjector), | ||
filterValues: dataSource.getFilterValues(columnConfig.id) | ||
filterValues: dataSource?.getFilterValues(columnConfig.id) ?? [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jake-bassett We already update filter values inside initializeData
private initializeData(): void {
if (!this.canBuildDataSource()) {
this.dataSource = undefined;
return;
}
this.dataSource = this.buildDataSource();
this.dataSource?.loadingStateChange$.subscribe(() => {
this.tableService.updateFilterValues(this.columnConfigsSubject.value, this.dataSource!); // Mutation! Ew!
});
this.filtersSubject.next(this.filters || []);
this.initializeRows();
}
Codecov Report
@@ Coverage Diff @@
## main #326 +/- ##
==========================================
- Coverage 86.17% 86.16% -0.01%
==========================================
Files 721 721
Lines 14674 14675 +1
Branches 1875 1876 +1
==========================================
Hits 12645 12645
- Misses 1997 2000 +3
+ Partials 32 30 -2
Continue to review full report at Codecov.
|
No description provided.