Skip to content

Conversation

anandtiwary
Copy link
Contributor

No description provided.

renderer: rendererConstructor,
parser: new parserConstructor(this.rootInjector),
filterValues: dataSource.getFilterValues(columnConfig.id)
filterValues: dataSource?.getFilterValues(columnConfig.id) ?? []
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jake-bassett We already update filter values inside initializeData

  private initializeData(): void {
    if (!this.canBuildDataSource()) {
      this.dataSource = undefined;

      return;
    }

    this.dataSource = this.buildDataSource();
    this.dataSource?.loadingStateChange$.subscribe(() => {
      this.tableService.updateFilterValues(this.columnConfigsSubject.value, this.dataSource!); // Mutation! Ew!
    });
    this.filtersSubject.next(this.filters || []);

    this.initializeRows();
  }

@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #326 into main will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #326      +/-   ##
==========================================
- Coverage   86.17%   86.16%   -0.01%     
==========================================
  Files         721      721              
  Lines       14674    14675       +1     
  Branches     1875     1876       +1     
==========================================
  Hits        12645    12645              
- Misses       1997     2000       +3     
+ Partials       32       30       -2     
Impacted Files Coverage Δ
...components/src/table/data/table-cdk-data-source.ts 83.07% <100.00%> (ø)
projects/components/src/table/table.component.ts 91.86% <100.00%> (-0.39%) ⬇️
projects/components/src/table/table.service.ts 100.00% <100.00%> (ø)
...pover/position-strategy/mouse-position-strategy.ts 9.67% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cf5d71...d660873. Read the comment docs.

@anandtiwary anandtiwary marked this pull request as ready for review November 4, 2020 20:50
@anandtiwary anandtiwary requested a review from a team as a code owner November 4, 2020 20:50
@anandtiwary anandtiwary merged commit 606a805 into main Nov 4, 2020
@anandtiwary anandtiwary deleted the table-fix branch November 4, 2020 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants