fix: toggle button group updates #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjindal93
reviewed
Nov 6, 2020
projects/components/src/toggle-button-group/toggle-button-group.component.ts
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #336 +/- ##
========================================
Coverage 86.20% 86.20%
========================================
Files 721 721
Lines 14680 14684 +4
Branches 1745 1877 +132
========================================
+ Hits 12655 12659 +4
Misses 1995 1995
Partials 30 30
Continue to review full report at Codecov.
|
Contributor
aaron-steinfeld
left a comment
aaron-steinfeld
left a comment
There was a problem hiding this comment.
The implementation is fine, but I'd like to discuss where we might see using spaced out toggle buttons before adding this.
aaron-steinfeld
approved these changes
Nov 6, 2020
Contributor
aaron-steinfeld
left a comment
aaron-steinfeld
left a comment
There was a problem hiding this comment.
Discussed offline - in full page views, we generally want default justification, while modal views are centered/space between.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Take justifyContent property as an input to toggle button group.
Minor CSS updates.
Testing
Manual verification.