Gauge with layout service #339
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Using angular svg binding - Using d3 shape to build arc path string - Using resize observer to react on dom dimension changes
| } | ||
|
|
||
| public onLayoutChange(): void { | ||
| this.redrawSubject.next(true); |
There was a problem hiding this comment.
Not wrong, but a bit strange to do this with a subject. Could just as easily remove the subject + combineLatest and do
this.gaugeRendererData$ = this.buildGaugeRendererDataObservable();
| </svg> | ||
| `, | ||
| styleUrls: ['./gauge.component.scss'], | ||
| providers: [LayoutChangeService], |
There was a problem hiding this comment.
Not needed - that's why we have the directive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change, motivation and context.
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.