Skip to content

Conversation

@anandtiwary
Copy link
Contributor

Description

Please include a summary of the change, motivation and context.
Loading Gauge threshold model

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@anandtiwary anandtiwary requested a review from a team as a code owner November 12, 2020 01:09
@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #350 (f048b81) into main (c0fba1c) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #350      +/-   ##
==========================================
+ Coverage   86.22%   86.27%   +0.04%     
==========================================
  Files         729      729              
  Lines       14843    14844       +1     
  Branches     1760     1847      +87     
==========================================
+ Hits        12799    12806       +7     
+ Misses       2013     2005       -8     
- Partials       31       33       +2     
Impacted Files Coverage Δ
...red/dashboard/widgets/gauge/gauge-widget.module.ts 100.00% <100.00%> (ø)
...pover/position-strategy/mouse-position-strategy.ts 9.67% <0.00%> (ø)
.../widgets/gauge/thresholds/gauge-threshold.model.ts 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0fba1c...f048b81. Read the comment docs.

@anandtiwary anandtiwary merged commit 745637e into main Nov 12, 2020
@anandtiwary anandtiwary deleted the add-threshold-to-module branch November 12, 2020 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants