Skip to content

Conversation

@skjindal93
Copy link
Contributor

Description

Adds label to the icon cell renderer component

Testing

Tested via unit tests and verifying the label working manually on the UI

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@skjindal93 skjindal93 requested a review from a team as a code owner November 13, 2020 07:50
@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #353 (949bcb3) into main (1767a7b) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #353      +/-   ##
==========================================
+ Coverage   86.27%   86.28%   +0.01%     
==========================================
  Files         729      729              
  Lines       14844    14844              
  Branches     1896     1896              
==========================================
+ Hits        12806    12808       +2     
+ Misses       2007     2003       -4     
- Partials       31       33       +2     
Impacted Files Coverage Δ
...table/cells/data-parsers/table-cell-icon-parser.ts 100.00% <ø> (+18.18%) ⬆️
...nderers/icon/icon-table-cell-renderer.component.ts 100.00% <ø> (ø)
...pover/position-strategy/mouse-position-strategy.ts 9.67% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1767a7b...949bcb3. Read the comment docs.

@skjindal93 skjindal93 merged commit cf7a203 into main Nov 13, 2020
@skjindal93 skjindal93 deleted the Add+Label+To+Icon+Cell+Renderer branch November 13, 2020 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants