Skip to content

Conversation

@skjindal93
Copy link
Contributor

Description

Edit Columns option on the table used to show the entire set of columns, instead of just the visible columns. Fixed it to use the visible columns config

Testing

Verified manually by deploying UI locally

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@skjindal93 skjindal93 requested a review from a team as a code owner November 13, 2020 08:48
Copy link
Contributor

@arjunlalb arjunlalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #354 (3b29b01) into main (cf7a203) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #354   +/-   ##
=======================================
  Coverage   86.28%   86.28%           
=======================================
  Files         729      729           
  Lines       14844    14844           
  Branches     1896     1896           
=======================================
  Hits        12808    12808           
  Misses       2003     2003           
  Partials       33       33           
Impacted Files Coverage Δ
projects/components/src/table/table.component.ts 91.50% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf7a203...3b29b01. Read the comment docs.

@skjindal93 skjindal93 merged commit 46b4982 into main Nov 13, 2020
@skjindal93 skjindal93 deleted the Display+Only+Visible+Columns+For+Edit+Columns branch November 13, 2020 08:58
Copy link
Contributor

@jake-bassett jake-bassett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is going to break add/remove column.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants