Skip to content

fix: explorer table expanding beyond page bounds #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 8, 2021
Merged

fix: explorer table expanding beyond page bounds #485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bcadc90
fix: explorer table expanding beyond page bounds
jake-bassett Jan 7, 2021
e463a6a
fix: change oveflow to hidden for clarity
jake-bassett Jan 7, 2021
e8e6c59
fix: safari squishing
jake-bassett Jan 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion projects/components/src/paginator/paginator.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
align-items: center;

height: $paginator-height;
padding-top: 6px;
padding: 6px 0;
border-top: 1px solid $color-border;

.label {
Expand Down
2 changes: 1 addition & 1 deletion projects/components/src/panel/panel.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
border-radius: 2px;

&.expanded {
margin-bottom: 8px;
padding-bottom: 8px;
}

.header-content {
Expand Down
4 changes: 0 additions & 4 deletions projects/components/src/table/table.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,7 @@
@import 'layout';

.table {
display: flex;
flex-direction: column;
height: 100%;
width: 100%;
position: relative;
}

.title-row {
Expand Down
4 changes: 2 additions & 2 deletions ...stributed-tracing/src/shared/dashboard/widgets/table/table-widget-renderer.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
}

.table {
flex: 1 1;
width: 100%;
flex: 1;
min-height: 0;
}

.header-margin {
Expand Down
36 changes: 28 additions & 8 deletions projects/observability/src/pages/explorer/explorer.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,40 @@
@import 'font';

.explorer-container {
.explorer {
display: flex;
flex-direction: column;
padding: 24px 24px 0;
height: calc(100% - 40px);
overflow: hidden;
height: 100%;

.filter-bar {
margin-top: 16px;
.explorer-header {
flex: 0;
}

.explorer-content {
display: flex;
flex-direction: column;
padding: 24px 24px 0;
flex: 1;
min-height: 0;
}

.explorer-data-toggle {
flex: 0;
padding-bottom: 16px;
}

.explorer-filter-bar {
flex: 0;
padding-bottom: 8px;
}

.panel-title {
color: black;
}

.visualization-panel {
padding-top: 8px;
flex: 0;

.label {
@include body-1-medium;
}
Expand All @@ -29,14 +48,15 @@
}

.results-panel {
flex: 1;
overflow: hidden;
flex: 1 1 auto;

.label {
@include body-1-medium;
}

.results-panel-content {
margin-top: 12px;
padding-top: 12px;
}
}
}
9 changes: 5 additions & 4 deletions projects/observability/src/pages/explorer/explorer.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,17 +19,18 @@ import {
styleUrls: ['./explorer.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
template: `
<div class="vertical-flex-layout">
<ht-page-header></ht-page-header>
<div class="fill-container explorer-container">
<div class="explorer">
<ht-page-header class="explorer-header"></ht-page-header>
<div class="explorer-content">
<ht-toggle-group
class="explorer-data-toggle"
[items]="this.contextItems"
[activeItem]="this.activeContextItem$ | async"
(activeItemChange)="this.onContextUpdated($event.value)"
></ht-toggle-group>

<ht-filter-bar
class="filter-bar"
class="explorer-filter-bar"
[attributes]="this.attributes$ | async"
[syncWithUrl]="true"
(filtersChange)="this.onFiltersUpdated($event)"
Expand Down