feat: change table controls to more generic view toggle instead of mode #523
Conversation
| type: 'table-widget', | ||
| id: 'service-list.table', | ||
| mode: TableMode.Flat, | ||
| style: TableStyle.FullPage, |
There was a problem hiding this comment.
Added FullPage here to push the pagination to the bottom.
Codecov Report
@@ Coverage Diff @@
## main #523 +/- ##
==========================================
- Coverage 85.60% 85.57% -0.04%
==========================================
Files 757 758 +1
Lines 15519 15524 +5
Branches 1839 1839
==========================================
- Hits 13285 13284 -1
- Misses 2203 2209 +6
Partials 31 31
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| public onModeChange(mode: TableMode): void { | ||
| this.activeMode = mode; | ||
| this.model.setMode(mode); | ||
| } |
There was a problem hiding this comment.
on mode change is only called in on init now right? we can probably just remove this method, that call and change the template to use this.model.mode directly.
| key: 'view', | ||
| type: STRING_PROPERTY.type | ||
| }) | ||
| public view!: string; |
There was a problem hiding this comment.
Is this the label that appears in the dropdown? If so, it's name could be updated to clarify.
…-widget-controls-view-toggle
…race/hypertrace-ui into table-widget-controls-view-toggle
This comment has been minimized.
This comment has been minimized.
Description