Skip to content

Conversation

DmitiryPotychkin
Copy link
Contributor

@DmitiryPotychkin DmitiryPotychkin commented Jan 25, 2021

  • change padding
  • change location of toggle button

@DmitiryPotychkin DmitiryPotychkin requested a review from a team as a code owner January 25, 2021 12:02
@codecov
Copy link

codecov bot commented Jan 25, 2021

Codecov Report

Merging #530 (26b9435) into main (64c2a94) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #530   +/-   ##
=======================================
  Coverage   85.60%   85.60%           
=======================================
  Files         757      757           
  Lines       15519    15519           
  Branches     1839     1839           
=======================================
  Hits        13285    13285           
  Misses       2203     2203           
  Partials       31       31           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64c2a94...26b9435. Read the comment docs.

@DmitiryPotychkin
Copy link
Contributor Author

DmitiryPotychkin commented Jan 25, 2021

Also I suggest to add scroll into this component to handle cases when height of user's screen is smaller than height of navigation, rough example how it may look:

@aaron-steinfeld
Copy link
Contributor

Also I suggest to add scroll into this component to handle cases when height of user's screen is smaller than height of navigation

We definitely should be handling that case, but I thought the plan was that the whole page should be scrolling, as we don't want separate scrollbars on the side nav and the content. Taking a quick look at the UI today it looks like the content already scrolls separately and the nav just gets clipped - so it should be addressed in some manner. If we want to throw a scroll on it for now, either in this PR or another - that's fine until we come up with something more elegant.

@aaron-steinfeld aaron-steinfeld merged commit 647bbe5 into hypertrace:main Jan 25, 2021
@github-actions
Copy link

Unit Test Results

    4 files  ±0  232 suites  ±0   12m 33s ⏱️ -57s
818 tests ±0  818 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
822 runs  ±0  822 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 647bbe5. ± Comparison against base commit 64c2a94.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants