Skip to content

Conversation

anandtiwary
Copy link
Contributor

@anandtiwary anandtiwary commented Jan 27, 2021

Description

Please include a summary of the change, motivation and context.
feat: adding sheet ref

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@anandtiwary
Copy link
Contributor Author

@aaron-steinfeld does this look right. I am working on adding tests.

@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #536 (893a2b3) into main (7ad445c) will increase coverage by 0.03%.
The diff coverage is 84.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #536      +/-   ##
==========================================
+ Coverage   85.57%   85.60%   +0.03%     
==========================================
  Files         758      759       +1     
  Lines       15525    15545      +20     
  Branches     1839     1842       +3     
==========================================
+ Hits        13285    13307      +22     
+ Misses       2209     2207       -2     
  Partials       31       31              
Impacted Files Coverage Δ
...s/waterfall/waterfall-widget-renderer.component.ts 46.66% <25.00%> (+1.50%) ⬆️
...il-sheet/detail-sheet-interaction-handler.model.ts 80.00% <50.00%> (ø)
.../components/src/overlay/sheet/default-sheet-ref.ts 94.11% <94.11%> (ø)
projects/components/src/overlay/overlay.service.ts 100.00% <100.00%> (ø)
projects/components/src/overlay/sheet/sheet.ts 100.00% <100.00%> (ø)
...-sheet/detail-sheet-interaction-handler.service.ts 87.50% <100.00%> (ø)
projects/components/src/popover/popover-ref.ts 93.54% <0.00%> (+3.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ad445c...893a2b3. Read the comment docs.

@github-actions

This comment has been minimized.

Copy link
Contributor

@aaron-steinfeld aaron-steinfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions

This comment has been minimized.

@anandtiwary anandtiwary marked this pull request as ready for review January 27, 2021 19:52
@anandtiwary anandtiwary requested a review from a team as a code owner January 27, 2021 19:52
@github-actions

This comment has been minimized.

@anandtiwary anandtiwary merged commit bd4d0b3 into main Jan 27, 2021
@anandtiwary anandtiwary deleted the add-sheet-ref branch January 27, 2021 20:00
@github-actions
Copy link

Unit Test Results

    4 files  ±0  232 suites  ±0   14m 46s ⏱️ +30s
821 tests +1  821 ✔️ +1  0 💤 ±0  0 ❌ ±0 
825 runs  +1  825 ✔️ +1  0 💤 ±0  0 ❌ ±0 

Results for commit bd4d0b3. ± Comparison against base commit 7ad445c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants