Skip to content

Conversation

arjunlalb
Copy link
Contributor

@arjunlalb arjunlalb commented Jan 27, 2021

Description

Add large size support for select component

Testing

N/A

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@arjunlalb arjunlalb requested a review from a team as a code owner January 27, 2021 12:24
@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #537 (50b3c96) into main (1a9409f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #537   +/-   ##
=======================================
  Coverage   85.57%   85.57%           
=======================================
  Files         758      758           
  Lines       15525    15525           
  Branches     1839     1839           
=======================================
  Hits        13285    13285           
  Misses       2209     2209           
  Partials       31       31           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a9409f...50b3c96. Read the comment docs.

@github-actions

This comment has been minimized.

Copy link
Contributor

@aaron-steinfeld aaron-steinfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the height of the select component is specified by the size input, it should not be inherited

@arjunlalb arjunlalb changed the title fix: make select trigger height inheritable fix: add large size for Select component Jan 27, 2021
@github-actions

This comment has been minimized.

@arjunlalb arjunlalb merged commit 3b1f8be into main Jan 27, 2021
@arjunlalb arjunlalb deleted the select-inherit-height branch January 27, 2021 14:27
@github-actions
Copy link

Unit Test Results

    4 files  ±0  232 suites  ±0   14m 16s ⏱️ +41s
818 tests ±0  818 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
822 runs  ±0  822 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3b1f8be. ± Comparison against base commit 1a9409f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants