Skip to content

Conversation

aaron-steinfeld
Copy link
Contributor

Description

Unifying the top nav color through style overrides overrode the emphasized style for the refresh button, which we want to keep. This changes the override to only apply when the refresh button is not meant to be emphasized.

Testing

Visual verification

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@aaron-steinfeld aaron-steinfeld requested a review from a team as a code owner January 28, 2021 19:26
@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #540 (c18db6e) into main (9e6502a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             main     #540    +/-   ##
========================================
  Coverage   85.60%   85.60%            
========================================
  Files         759      759            
  Lines       15549    15549            
  Branches     1842     1985   +143     
========================================
  Hits        13311    13311            
+ Misses       2207     2205     -2     
- Partials       31       33     +2     
Impacted Files Coverage Δ
.../components/src/time-range/time-range.component.ts 97.14% <ø> (ø)
...pover/position-strategy/mouse-position-strategy.ts 9.67% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e6502a...c18db6e. Read the comment docs.

@github-actions

This comment has been minimized.

@aaron-steinfeld aaron-steinfeld merged commit 5685d21 into main Jan 28, 2021
@aaron-steinfeld aaron-steinfeld deleted the leave-tr-refresh-color branch January 28, 2021 19:52
@github-actions
Copy link

Unit Test Results

    4 files  ±0  232 suites  ±0   13m 9s ⏱️ +57s
822 tests ±0  822 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
826 runs  ±0  826 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 5685d21. ± Comparison against base commit 9e6502a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants