Skip to content

Conversation

arjunlalb
Copy link
Contributor

Description

Support for parsing ISO 8601 duration string

Testing

UT added.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@arjunlalb arjunlalb requested a review from a team as a code owner January 29, 2021 15:35
@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #545 (5aeb886) into main (d9680cf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #545   +/-   ##
=======================================
  Coverage   85.60%   85.61%           
=======================================
  Files         759      759           
  Lines       15551    15554    +3     
  Branches     1985     1985           
=======================================
+ Hits        13313    13316    +3     
  Misses       2205     2205           
  Partials       33       33           
Impacted Files Coverage Δ
projects/common/src/time/time-duration.ts 95.00% <100.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9680cf...5aeb886. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@arjunlalb arjunlalb merged commit de73b05 into main Jan 29, 2021
@arjunlalb arjunlalb deleted the parse-duration-string branch January 29, 2021 16:31
@github-actions
Copy link

Unit Test Results

    4 files  ±0  232 suites  ±0   13m 34s ⏱️ +25s
824 tests +1  824 ✔️ +1  0 💤 ±0  0 ❌ ±0 
828 runs  +1  828 ✔️ +1  0 💤 ±0  0 ❌ ±0 

Results for commit de73b05. ± Comparison against base commit d9680cf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants