Skip to content

Conversation

arjunlalb
Copy link
Contributor

Description

support for includeInactive param in entities gql request

Testing

Manually tested. UTs added.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@arjunlalb arjunlalb requested a review from a team as a code owner February 1, 2021 04:24
@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #549 (92beeb1) into main (6e35969) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #549   +/-   ##
=======================================
  Coverage   85.59%   85.59%           
=======================================
  Files         760      760           
  Lines       15581    15583    +2     
  Branches     1988     1989    +1     
=======================================
+ Hits        13337    13339    +2     
  Misses       2211     2211           
  Partials       33       33           
Impacted Files Coverage Δ
...es/query/entities-graphql-query-builder.service.ts 100.00% <ø> (ø)
...argument/graphql-observability-argument-builder.ts 84.90% <100.00%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e35969...92beeb1. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@arjunlalb arjunlalb merged commit ba44156 into main Feb 1, 2021
@arjunlalb arjunlalb deleted the add-include-inactive-support branch February 1, 2021 05:45
@github-actions
Copy link

github-actions bot commented Feb 1, 2021

Unit Test Results

    4 files  ±0  233 suites  ±0   13m 48s ⏱️ +33s
829 tests +1  829 ✔️ +1  0 💤 ±0  0 ❌ ±0 
833 runs  +1  833 ✔️ +1  0 💤 ±0  0 ❌ ±0 

Results for commit ba44156. ± Comparison against base commit 6e35969.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants