Skip to content

Conversation

arjunlalb
Copy link
Contributor

Description

Icon only mode for select trigger

Testing

UTs added. Manually tested.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@arjunlalb arjunlalb requested a review from a team as a code owner February 1, 2021 18:58
@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #558 (b1f9aa1) into main (1a1d4ff) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #558   +/-   ##
=======================================
  Coverage   85.59%   85.59%           
=======================================
  Files         760      760           
  Lines       15588    15591    +3     
  Branches     1992     1992           
=======================================
+ Hits        13342    13345    +3     
  Misses       2213     2213           
  Partials       33       33           
Impacted Files Coverage Δ
projects/components/src/select/select.component.ts 94.00% <100.00%> (+0.25%) ⬆️
projects/components/src/select/select.module.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a1d4ff...b1f9aa1. Read the comment docs.

@github-actions

This comment has been minimized.

Copy link
Contributor

@aaron-steinfeld aaron-steinfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need a similar change for multi select right? Realized the use case I was aware of at least is using this mode with multi-select, not the standard select.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@arjunlalb arjunlalb merged commit b8514b1 into main Feb 2, 2021
@arjunlalb arjunlalb deleted the select-icon-only branch February 2, 2021 16:40
@github-actions
Copy link

github-actions bot commented Feb 2, 2021

Unit Test Results

    4 files  ±0  233 suites  ±0   12m 28s ⏱️ - 1m 39s
831 tests +2  831 ✔️ +2  0 💤 ±0  0 ❌ ±0 
835 runs  +2  835 ✔️ +2  0 💤 ±0  0 ❌ ±0 

Results for commit b8514b1. ± Comparison against base commit 1a1d4ff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants