Description component improve #579
Conversation
DmitiryPotychkin
commented
Feb 10, 2021
DmitiryPotychkin
commented
- stop event bubbling after click on component's buttons
- add ability to pass content in component, display it in line with description text
…ce-ui into ht-description
Codecov Report
@@ Coverage Diff @@
## main #579 +/- ##
==========================================
- Coverage 85.40% 85.37% -0.04%
==========================================
Files 765 765
Lines 15719 15719
Branches 1996 1996
==========================================
- Hits 13425 13420 -5
- Misses 2261 2266 +5
Partials 33 33
Continue to review full report at Codecov.
|
| data-sensitive-pii | ||
| #eventDescriptionText | ||
| > | ||
| <ng-content></ng-content> |
There was a problem hiding this comment.
I'm not against using content to pass in the description, but it's an alternative API to passing in description as an input - we shouldn't have both. If we have use cases that need more than a simple string passed in, let's make this the sole API to pass in content and remove the description input.
There was a problem hiding this comment.
Curious to know why we need ng-content? Is their an example usage I could see? Is it suppose to wrap any other component apart from a string?
There was a problem hiding this comment.
I think the main use cases are links and formatted strings
There was a problem hiding this comment.
okay.. Links we should handle from outside, but i see the need for formatted strings.
3 participants
