Skip to content

Conversation

DmitiryPotychkin
Copy link
Contributor

  • change icon and placeholder color
  • change icon size
  • change input's padding

@DmitiryPotychkin DmitiryPotychkin requested a review from a team as a code owner February 11, 2021 19:03
@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #588 (a216efa) into main (6d1775f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #588   +/-   ##
=======================================
  Coverage   85.35%   85.35%           
=======================================
  Files         766      766           
  Lines       15789    15789           
  Branches     2016     2016           
=======================================
  Hits        13476    13476           
  Misses       2280     2280           
  Partials       33       33           
Impacted Files Coverage Δ
.../components/src/search-box/search-box.component.ts 78.12% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d1775f...a216efa. Read the comment docs.

@anandtiwary
Copy link
Contributor

not sure why the publish unit test job is failing

@aaron-steinfeld
Copy link
Contributor

not sure why the publish unit test job is failing

I've been meaning to fix that - on forked PRs, it will always fail because it needs edit permissions to push results.

@anandtiwary
Copy link
Contributor

cool. So we can ignore it for this PR then

@anandtiwary anandtiwary merged commit 7db1ade into hypertrace:main Feb 12, 2021
@github-actions
Copy link

Unit Test Results

    4 files  ±0  235 suites  ±0   14m 1s ⏱️ -39s
844 tests ±0  844 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
848 runs  ±0  848 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 7db1ade. ± Comparison against base commit 6d1775f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants