Skip to content

Conversation

jake-bassett
Copy link
Contributor

Description

Add an additional model property to cartesian widget to allow band data fetching to be disabled.

@jake-bassett jake-bassett requested a review from a team as a code owner February 16, 2021 21:08
@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #602 (a4afeee) into main (14a3264) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #602   +/-   ##
=======================================
  Coverage   85.08%   85.08%           
=======================================
  Files         768      768           
  Lines       15854    15856    +2     
  Branches     2035     2036    +1     
=======================================
+ Hits        13489    13491    +2     
  Misses       2332     2332           
  Partials       33       33           
Impacted Files Coverage Δ
.../charts/cartesian-widget/cartesian-widget.model.ts 72.61% <100.00%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14a3264...a4afeee. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@jake-bassett jake-bassett merged commit cda2439 into main Feb 16, 2021
@jake-bassett jake-bassett deleted the cartesian-widget-property-disable-bands branch February 16, 2021 22:15
@github-actions
Copy link

Unit Test Results

    4 files  ±0  235 suites  ±0   14m 47s ⏱️ +48s
844 tests ±0  844 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
848 runs  ±0  848 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit cda2439. ± Comparison against base commit 14a3264.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants