Skip to content

Conversation

jake-bassett
Copy link
Contributor

Description

Added configuration for cartesian health bands to overview and metric dashboards. Turned off by default.

@jake-bassett jake-bassett requested a review from a team as a code owner February 16, 2021 22:33
@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #603 (a738259) into main (cda2439) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #603      +/-   ##
==========================================
+ Coverage   85.08%   85.15%   +0.06%     
==========================================
  Files         768      768              
  Lines       15856    15856              
  Branches     2036     2036              
==========================================
+ Hits        13491    13502      +11     
+ Misses       2332     2321      -11     
  Partials       33       33              
Impacted Files Coverage Δ
...s/apis/api-detail/metrics/api-metrics.dashboard.ts 100.00% <ø> (ø)
...apis/api-detail/overview/api-overview.dashboard.ts 100.00% <ø> (ø)
...ervice-detail/metrics/service-metrics.dashboard.ts 100.00% <ø> (ø)
...vice-detail/overview/service-overview.dashboard.ts 100.00% <ø> (ø)
...s/apis/api-detail/metrics/api-metrics.component.ts 100.00% <100.00%> (ø)
...ages/apis/api-detail/metrics/api-metrics.module.ts 100.00% <100.00%> (ø)
...ervice-detail/metrics/service-metrics.component.ts 100.00% <100.00%> (ø)
projects/observability/src/public-api.ts 100.00% <100.00%> (ø)
.../charts/cartesian-widget/cartesian-widget.model.ts 72.61% <100.00%> (ø)
.../selections/observability-specification-builder.ts 64.21% <0.00%> (+5.26%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cda2439...a738259. Read the comment docs.

@github-actions

This comment has been minimized.

@jake-bassett jake-bassett merged commit a11d1c7 into main Feb 16, 2021
@jake-bassett jake-bassett deleted the enable-metric-cartesian-health branch February 16, 2021 22:38
@github-actions
Copy link

Unit Test Results

    4 files  ±0  235 suites  ±0   13m 59s ⏱️ -48s
844 tests ±0  844 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
848 runs  ±0  848 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a11d1c7. ± Comparison against base commit cda2439.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants