Skip to content

Conversation

jake-bassett
Copy link
Contributor

Description

Time agnostic APIs

@jake-bassett jake-bassett requested a review from a team as a code owner February 17, 2021 01:48
@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

Merging #604 (d614706) into main (abcfcad) will increase coverage by 0.00%.
The diff coverage is 84.21%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #604   +/-   ##
=======================================
  Coverage   85.15%   85.15%           
=======================================
  Files         768      768           
  Lines       15861    15868    +7     
  Branches     2037     2043    +6     
=======================================
+ Hits        13506    13513    +7     
+ Misses       2322     2321    -1     
- Partials       33       34    +1     
Impacted Files Coverage Δ
...ts/assets-library/src/icons/icon-library.module.ts 100.00% <ø> (ø)
...oard/copy-shareable-link-to-clipboard.component.ts 54.54% <ø> (ø)
projects/components/src/select/select.component.ts 94.54% <ø> (ø)
...nderers/text/text-table-cell-renderer.component.ts 100.00% <ø> (ø)
...nts/src/table/controls/table-controls.component.ts 77.41% <ø> (ø)
...ell/metric/metric-table-cell-renderer.component.ts 100.00% <ø> (ø)
...nents/entity-renderer/entity-renderer.component.ts 100.00% <ø> (ø)
...te/entities-attribute-options-data-source.model.ts 45.45% <0.00%> (ø)
...hql/table/entity/entity-table-data-source.model.ts 84.37% <ø> (ø)
...tilities/formatters/numeric/display-number.pipe.ts 80.00% <50.00%> (-2.61%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abcfcad...d614706. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

return this.extractUnits(cellData)!;
}

// tslint:disable-next-line:no-null-undefined-union
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this lint rule no longer needed

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@jake-bassett jake-bassett merged commit 23cf371 into main Feb 18, 2021
@jake-bassett jake-bassett deleted the time-agnostic-endpoints branch February 18, 2021 19:03
@github-actions
Copy link

Unit Test Results

    4 files  ±0  235 suites  ±0   14m 28s ⏱️ +4s
844 tests ±0  844 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
848 runs  ±0  848 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 23cf371. ± Comparison against base commit bd0ed29.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants