-
Notifications
You must be signed in to change notification settings - Fork 11
feat: separate zoom into a shared util file #606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #606 +/- ##
==========================================
- Coverage 85.15% 85.15% -0.01%
==========================================
Files 768 769 +1
Lines 15868 15884 +16
Branches 2043 2046 +3
==========================================
+ Hits 13513 13526 +13
- Misses 2321 2324 +3
Partials 34 34
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming this is just a refactor to pull out a base zoom class to use in other vizs?
Sorry I meant to post this but got distracted. The only code change I did (apart from refactor) is
to
But this is not required since the brush feature addition. I have verified it. And I will be making some more changes to this in the next few days. |
Description
Please include a summary of the change, motivation and context.
feat: separate zoom into a shared util file
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.