Skip to content

Conversation

anandtiwary
Copy link
Contributor

@anandtiwary anandtiwary commented Feb 17, 2021

Description

Please include a summary of the change, motivation and context.
feat: separate zoom into a shared util file

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

Merging #606 (9d92fa6) into main (23cf371) will decrease coverage by 0.00%.
The diff coverage is 69.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #606      +/-   ##
==========================================
- Coverage   85.15%   85.15%   -0.01%     
==========================================
  Files         768      769       +1     
  Lines       15868    15884      +16     
  Branches     2043     2046       +3     
==========================================
+ Hits        13513    13526      +13     
- Misses       2321     2324       +3     
  Partials       34       34              
Impacted Files Coverage Δ
...ity/src/shared/components/utils/d3/zoom/d3-zoom.ts 67.74% <67.74%> (ø)
...nts/topology/d3/interactions/zoom/topology-zoom.ts 58.82% <87.50%> (-5.52%) ⬇️
projects/observability/src/public-api.ts 100.00% <100.00%> (ø)
...y/src/shared/components/topology/d3/d3-topology.ts 92.59% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23cf371...9d92fa6. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@anandtiwary anandtiwary marked this pull request as ready for review February 18, 2021 19:19
@anandtiwary anandtiwary requested a review from a team as a code owner February 18, 2021 19:19
Copy link
Contributor

@aaron-steinfeld aaron-steinfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this is just a refactor to pull out a base zoom class to use in other vizs?

@anandtiwary
Copy link
Contributor Author

anandtiwary commented Feb 18, 2021

Sorry I meant to post this but got distracted. The only code change I did (apart from refactor) is

    this.setZoomScale(Math.min(1, Math.max(this.minScale, minOverallScale)));

to

 this.setZoomScale(Math.max(this.minScale, minOverallScale));

But this is not required since the brush feature addition. I have verified it. And I will be making some more changes to this in the next few days.

@github-actions

This comment has been minimized.

@anandtiwary anandtiwary merged commit efbf8da into main Feb 18, 2021
@anandtiwary anandtiwary deleted the d3-zoom-refactor branch February 18, 2021 21:42
@github-actions
Copy link

Unit Test Results

    4 files  ±0  235 suites  ±0   14m 55s ⏱️ +27s
844 tests ±0  844 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
848 runs  ±0  848 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit efbf8da. ± Comparison against base commit 23cf371.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants