Skip to content

Conversation

arjunlalb
Copy link
Contributor

@arjunlalb arjunlalb commented Feb 18, 2021

Description

Add support for a separate selectedLabel for select options in select component.

In some cases we'd want to show a different label when the action is selected. For example, when the option is an action like 'Resolve', we'd want to show 'Resolved' when that option is selected.

Testing

UTs added.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@arjunlalb arjunlalb requested a review from a team as a code owner February 18, 2021 11:12
@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #607 (3b83b23) into main (abcfcad) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #607   +/-   ##
=======================================
  Coverage   85.15%   85.15%           
=======================================
  Files         768      768           
  Lines       15861    15862    +1     
  Branches     2037     2037           
=======================================
+ Hits        13506    13507    +1     
  Misses       2322     2322           
  Partials       33       33           
Impacted Files Coverage Δ
projects/components/src/select/select.component.ts 94.54% <ø> (ø)
...s/components/src/select/select-option.component.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abcfcad...3b83b23. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@arjunlalb arjunlalb merged commit 9fa4519 into main Feb 18, 2021
@arjunlalb arjunlalb deleted the select-add-selected-label branch February 18, 2021 15:15
@github-actions
Copy link

Unit Test Results

    4 files  ±0  235 suites  ±0   14m 0s ⏱️ -23s
844 tests ±0  844 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
848 runs  ±0  848 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 9fa4519. ± Comparison against base commit abcfcad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants