-
Notifications
You must be signed in to change notification settings - Fork 11
feat: add time ago pipe for last called column #614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #614 +/- ##
==========================================
+ Coverage 85.15% 85.17% +0.02%
==========================================
Files 768 770 +2
Lines 15880 15905 +25
Branches 2046 2048 +2
==========================================
+ Hits 13522 13547 +25
Misses 2324 2324
Partials 34 34
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
projects/common/src/utilities/formatters/time/display-time-ago.pipe.ts
Outdated
Show resolved
Hide resolved
projects/common/src/utilities/formatters/time/display-time-ago.pipe.ts
Outdated
Show resolved
Hide resolved
projects/common/src/utilities/formatters/time/display-time-ago.pipe.ts
Outdated
Show resolved
Hide resolved
...components/src/table/cells/data-renderers/time-ago/time-ago-table-cell-renderer.component.ts
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
||
const value = mostSignificantPortion.value; | ||
const units = mostSignificantPortion.toUnitString(); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line 38-41 are basically a reimplementation of toLongString()
I believe. Rather than adding any code in time duration, I'd expect the timeAgo pipe to use duration (illustrated below). Putting this logic into time duration doesn't feel right because a duration has no reference to a point in time - it's only a length of time.
projects/common/src/utilities/formatters/time/display-time-ago.pipe.ts
Outdated
Show resolved
Hide resolved
….pipe.ts Co-authored-by: Aaron Steinfeld <45047841+aaron-steinfeld@users.noreply.github.com>
…nto time-ago-pipe
Description
Add time ago pipe and time ago cell renderer for Last Called column.