Skip to content

Conversation

jake-bassett
Copy link
Contributor

Description

Add time ago pipe and time ago cell renderer for Last Called column.

@jake-bassett jake-bassett requested a review from a team as a code owner February 19, 2021 01:33
@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #614 (4804c65) into main (8de3356) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #614      +/-   ##
==========================================
+ Coverage   85.15%   85.17%   +0.02%     
==========================================
  Files         768      770       +2     
  Lines       15880    15905      +25     
  Branches     2046     2048       +2     
==========================================
+ Hits        13522    13547      +25     
  Misses       2324     2324              
  Partials       34       34              
Impacted Files Coverage Δ
...rc/pages/apis/endpoints/endpoint-list.dashboard.ts 100.00% <ø> (ø)
...mmon/src/utilities/formatters/formatting.module.ts 100.00% <100.00%> (ø)
...utilities/formatters/time/display-time-ago.pipe.ts 100.00% <100.00%> (ø)
...time-ago/time-ago-table-cell-renderer.component.ts 100.00% <100.00%> (ø)
...s/components/src/table/cells/table-cells.module.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8de3356...4804c65. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.


const value = mostSignificantPortion.value;
const units = mostSignificantPortion.toUnitString();

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 38-41 are basically a reimplementation of toLongString() I believe. Rather than adding any code in time duration, I'd expect the timeAgo pipe to use duration (illustrated below). Putting this logic into time duration doesn't feel right because a duration has no reference to a point in time - it's only a length of time.

jake-bassett and others added 3 commits February 19, 2021 14:43
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@jake-bassett jake-bassett merged commit 9dd42c5 into main Feb 19, 2021
@jake-bassett jake-bassett deleted the time-ago-pipe branch February 19, 2021 23:06
@github-actions
Copy link

Unit Test Results

    4 files  ±0  236 suites  +1   15m 0s ⏱️ +5s
849 tests +5  849 ✔️ +5  0 💤 ±0  0 ❌ ±0 
853 runs  +5  853 ✔️ +5  0 💤 ±0  0 ❌ ±0 

Results for commit 9dd42c5. ± Comparison against base commit 8de3356.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants