refactor: move some types around to make table api friendlier #616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #616 +/- ##
==========================================
- Coverage 85.15% 85.15% -0.01%
==========================================
Files 769 768 -1
Lines 15884 15880 -4
Branches 2046 2046
==========================================
- Hits 13526 13522 -4
Misses 2324 2324
Partials 34 34
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
jake-bassett
approved these changes
Feb 19, 2021
| | TablePropertyControlOption<T>; | ||
|
|
||
| export interface TableUnsetFilterControlOption extends TableControlOption<string, undefined> { | ||
| interface TableControlOptionBase<T> { |
There was a problem hiding this comment.
Pfft. Who uses "Base" in a name? 🙄
There was a problem hiding this comment.
Hah - I hated every minute of it, but TableControlOption was already taken by someone!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The table api is a bit tied up in its dashboard usage, so refactored some types to make it easier to use programatically. Long term, the table doesn't care about most of the stuff in these controls, so there's more to be done here.
Testing
Tested E2E, reran unit tests. These are mostly type changes, so shouldn't affect any runtime behavior
Checklist: