feat: support searching in multi select component #625

arjunlalb · 2021-02-22T10:48:41Z

Description

Support searching in multi select component.

Testing

UTs added.

Checklist:

My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
Any dependent changes have been merged and published in downstream modules

codecov · 2021-02-22T10:52:29Z

Codecov Report

Merging #625 (f827828) into main (9e66d03) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #625   +/-   ##
=======================================
  Coverage   85.18%   85.18%           
=======================================
  Files         770      770           
  Lines       15905    15911    +6     
  Branches     2048     2050    +2     
=======================================
+ Hits        13548    13554    +6     
  Misses       2323     2323           
  Partials       34       34

Impacted Files	Coverage Δ
...ponents/src/multi-select/multi-select.component.ts	`95.71% <100.00%> (+0.25%)`	⬆️
...components/src/multi-select/multi-select.module.ts	`100.00% <100.00%> (ø)`
.../components/src/search-box/search-box.component.ts	`78.78% <100.00%> (+0.66%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e66d03...f827828. Read the comment docs.

projects/components/src/multi-select/multi-select.component.ts

anandtiwary · 2021-02-22T16:27:09Z

projects/components/src/multi-select/multi-select.component.ts

            </ng-container>

-            <div *ngFor="let item of items" (click)="this.onSelectionChange(item)" class="multi-select-option">
+            <ht-divider *ngIf="this.showAllOptionControl || this.enableSearch"></ht-divider>


The new mocks supports "Select All" And "Clear Selected" as buttons (instead of it as an option). Is this something you are taking care of too?

Not doing it at the moment. Currently doing things that would unblock me. Can circle back to it in the end.

github-actions · 2021-02-22T16:45:21Z

Unit Test Results

    4 files ±0 236 suites ±0 13m 54s ⏱️ -26s
852 tests +3 852 ✔️ +3 0 💤 ±0 0 ❌ ±0
856 runs +3 856 ✔️ +3 0 💤 ±0 0 ❌ ±0

Results for commit 2a6cd21. ± Comparison against base commit 9e66d03.

feat: support searching in multi select component

077112b

arjunlalb requested a review from a team as a code owner February 22, 2021 10:48

fix: fix lint issue

eea8f22