feat: add code table cell renderer #627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #627 +/- ##
=======================================
Coverage 85.20% 85.21%
=======================================
Files 772 773 +1
Lines 15936 15941 +5
Branches 2055 2055
=======================================
+ Hits 13579 13584 +5
Misses 2323 2323
Partials 34 34
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
jake-bassett
approved these changes
Feb 23, 2021
anandtiwary
reviewed
Feb 23, 2021
| styleUrls: ['./code-table-cell-renderer.component.scss'], | ||
| changeDetection: ChangeDetectionStrategy.OnPush, | ||
| template: ` | ||
| <div class="code-cell" [htTooltip]="this.value | htDisplayString"> |
There was a problem hiding this comment.
Is this code or just version? We might have to do more to support code view right?
There was a problem hiding this comment.
Version was just the example. It's code like backticks are code in markdown - not supposed to be multiline support in a table cell, although I guess we could add that if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a code-style table cell renderer that uses a gray background and monospaced font.
Testing
Added unit tests, verified in action. Also checked case of no data and data too long to fit to verify that they show "Unknown" and truncate, respectively.
Checklist: