Skip to content

Conversation

aaron-steinfeld
Copy link
Contributor

Description

The table was making more and more requests over time as inputs changed. Issue was we recreate data sources frequently, but there was a subscription inside the data source not being cleaned up on disconnect.

Testing

Manual verification + running existing tests

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@aaron-steinfeld aaron-steinfeld requested a review from a team as a code owner February 23, 2021 18:27
@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #628 (409ffa9) into main (9e94511) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #628   +/-   ##
=======================================
  Coverage   85.21%   85.21%           
=======================================
  Files         773      773           
  Lines       15941    15942    +1     
  Branches     2055     2056    +1     
=======================================
+ Hits        13584    13585    +1     
  Misses       2323     2323           
  Partials       34       34           
Impacted Files Coverage Δ
...components/src/table/data/table-cdk-data-source.ts 83.20% <100.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e94511...409ffa9. Read the comment docs.

@github-actions

This comment has been minimized.

@aaron-steinfeld aaron-steinfeld merged commit 5932bf4 into main Feb 23, 2021
@aaron-steinfeld aaron-steinfeld deleted the unsubscribe-table-on-disconnect branch February 23, 2021 18:36
@github-actions
Copy link

Unit Test Results

    4 files  ±0  238 suites  ±0   14m 27s ⏱️ -1s
858 tests ±0  858 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
862 runs  ±0  862 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 5932bf4. ± Comparison against base commit 9e94511.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants