Skip to content

Conversation

palbizu
Copy link
Contributor

@palbizu palbizu commented Feb 27, 2021

Description

General Toggle Button was re-styled (reduction of size), in this way the default styles of material were changed.

Testing

Visual Testing

Evidence;

image

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@palbizu palbizu requested a review from a team as a code owner February 27, 2021 00:25
@codecov
Copy link

codecov bot commented Feb 27, 2021

Codecov Report

Merging #645 (d6b7ddb) into main (cfc4509) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #645   +/-   ##
=======================================
  Coverage   85.20%   85.20%           
=======================================
  Files         777      777           
  Lines       16010    16010           
  Branches     2062     2062           
=======================================
  Hits        13642    13642           
  Misses       2334     2334           
  Partials       34       34           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfc4509...d6b7ddb. Read the comment docs.

@github-actions

This comment has been minimized.

@anandtiwary
Copy link
Contributor

please share before and after screenshot

@palbizu
Copy link
Contributor Author

palbizu commented Mar 1, 2021

@anandtiwary, added

@github-actions

This comment has been minimized.

@palbizu palbizu changed the title fix: defenseAISettingsMockAlignment fix: toggleButtonRestyling Mar 1, 2021
@github-actions

This comment has been minimized.

@palbizu palbizu merged commit 9c8510c into main Mar 1, 2021
@palbizu palbizu deleted the DefenseAISettingsMockAlignment branch March 1, 2021 17:50
@github-actions

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Mar 1, 2021

Unit Test Results

    4 files  ±0  241 suites  ±0   14m 5s ⏱️ +26s
866 tests ±0  866 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
870 runs  ±0  870 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 9c8510c. ± Comparison against base commit cfc4509.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants