Skip to content

Conversation

palbizu
Copy link
Contributor

@palbizu palbizu commented Mar 2, 2021

Description

  • Expand / Collapse button color changed when open (a variable was added to allow customization)
  • Left lateral dotted line was removed and the padding was adjusted to that position.

Testing

Visual test.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

image

@palbizu palbizu requested a review from a team as a code owner March 2, 2021 21:18
@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #653 (da68c2e) into main (10ba244) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #653   +/-   ##
=======================================
  Coverage   85.20%   85.20%           
=======================================
  Files         777      777           
  Lines       16017    16017           
  Branches     2066     2066           
=======================================
  Hits        13647    13647           
  Misses       2335     2335           
  Partials       35       35           
Impacted Files Coverage Δ
...mponents/src/expander/expander-toggle.component.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10ba244...da68c2e. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

aaron-steinfeld
aaron-steinfeld previously approved these changes Mar 2, 2021
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@palbizu palbizu merged commit 797268e into main Mar 2, 2021
@palbizu palbizu deleted the ExpandContractButtonStyling branch March 2, 2021 22:54
@github-actions
Copy link

github-actions bot commented Mar 2, 2021

Unit Test Results

    4 files  ±0  241 suites  ±0   15m 17s ⏱️ +33s
866 tests ±0  866 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
870 runs  ±0  870 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 797268e. ± Comparison against base commit 10ba244.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants