Skip to content

Conversation

jake-bassett
Copy link
Contributor

Description

  • Update styling for textarea (first usage)
  • Add taller large modal size

@jake-bassett jake-bassett requested a review from a team as a code owner March 2, 2021 21:57
@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #654 (395aa6f) into main (5fdec57) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #654   +/-   ##
=======================================
  Coverage   85.20%   85.20%           
=======================================
  Files         777      777           
  Lines       16017    16017           
  Branches     2066     2066           
=======================================
  Hits        13647    13647           
  Misses       2335     2335           
  Partials       35       35           
Impacted Files Coverage Δ
projects/components/src/modal/modal.ts 100.00% <ø> (ø)
...ects/components/src/textarea/textarea.component.ts 78.57% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fdec57...395aa6f. Read the comment docs.

@github-actions

This comment has been minimized.

width: 640px;
}

&.modal-size-large-tall {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably need to include Response size. We have done it for sheet and it would be useful to add it here. It is straightforward.

@jake-bassett jake-bassett merged commit 10ba244 into main Mar 2, 2021
@jake-bassett jake-bassett deleted the modal-and-textarea-styling branch March 2, 2021 22:32
@github-actions
Copy link

github-actions bot commented Mar 2, 2021

Unit Test Results

    4 files  ±0  241 suites  ±0   14m 44s ⏱️ -55s
866 tests ±0  866 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
870 runs  ±0  870 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 10ba244. ± Comparison against base commit 5fdec57.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants