Skip to content

fix: addressing comments on #656 #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 4, 2021
Merged

fix: addressing comments on #656 #657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6175c55
feat: validator for emails and a string formatter
arjunlalb Mar 4, 2021
e8dae5b
fix: update test strings
arjunlalb Mar 4, 2021
9f819bb
fix: address comments
arjunlalb Mar 4, 2021
15f9093
Merge branch 'main' into validator-formatter
arjunlalb Mar 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions projects/common/src/utilities/formatters/string/string-formatter.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ describe('String formatter', () => {
expect(getStringsFromCommaSeparatedList('first,second, third ')).toEqual(
expect.arrayContaining(['first', 'second', 'third'])
);
expect(getStringsFromCommaSeparatedList('first,second, ')).toEqual(expect.arrayContaining(['first', 'second']));
expect(getStringsFromCommaSeparatedList('first')).toEqual(expect.arrayContaining(['first']));
expect(getStringsFromCommaSeparatedList('first,second, ')).toEqual(['first', 'second']);
expect(getStringsFromCommaSeparatedList('first')).toEqual(['first']);
});
});
1 change: 0 additions & 1 deletion projects/common/src/utilities/formatters/string/string-formatter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ export const collapseWhitespace = (str: string): string =>

export const getStringsFromCommaSeparatedList = (text: string): string[] =>
text
.trim()
.split(',')
.map(part => part.trim())
.filter(part => part !== '');