Skip to content

Conversation

anandtiwary
Copy link
Contributor

@anandtiwary anandtiwary commented Mar 10, 2021

Description

Please include a summary of the change, motivation and context.
Only shows success message when at least one value has been emitted on source observable.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@anandtiwary anandtiwary requested a review from a team as a code owner March 10, 2021 01:27
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #673 (20d168e) into main (0234ae5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #673   +/-   ##
=======================================
  Coverage   85.22%   85.22%           
=======================================
  Files         780      780           
  Lines       16054    16056    +2     
  Branches     2070     2071    +1     
=======================================
+ Hits        13682    13684    +2     
  Misses       2337     2337           
  Partials       35       35           
Impacted Files Coverage Δ
...omponents/src/notification/notification.service.ts 96.29% <100.00%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0234ae5...20d168e. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@anandtiwary anandtiwary merged commit 3822823 into main Mar 10, 2021
@anandtiwary anandtiwary deleted the fix-notification-operator branch March 10, 2021 18:56
@github-actions
Copy link

Unit Test Results

    4 files  ±0  244 suites  ±0   15m 8s ⏱️ -50s
878 tests ±0  878 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
882 runs  ±0  882 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3822823. ± Comparison against base commit 0234ae5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants