Skip to content

Conversation

arjunlalb
Copy link
Contributor

Description

Cell renderer to display text with a copy action on hover.

Testing

Tested manually. UT added.

Screen.Recording.2021-03-10.at.5.55.03.PM.mov

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@arjunlalb arjunlalb requested a review from a team as a code owner March 10, 2021 12:28
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #676 (7867fcd) into main (fe7a18e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #676   +/-   ##
=======================================
  Coverage   85.21%   85.22%           
=======================================
  Files         779      780    +1     
  Lines       16046    16052    +6     
  Branches     2070     2070           
=======================================
+ Hits        13674    13680    +6     
  Misses       2337     2337           
  Partials       35       35           
Impacted Files Coverage Δ
...py/text-with-copy-table-cell-renderer.component.ts 100.00% <100.00%> (ø)
...s/components/src/table/cells/table-cells.module.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe7a18e...7867fcd. Read the comment docs.

@github-actions

This comment has been minimized.

@arjunlalb arjunlalb merged commit fc33c22 into main Mar 10, 2021
@arjunlalb arjunlalb deleted the text-with-copy-action-cell-renderer branch March 10, 2021 13:15
@github-actions
Copy link

Unit Test Results

    4 files  ±0  244 suites  +1   14m 34s ⏱️ +10s
878 tests +6  878 ✔️ +6  0 💤 ±0  0 ❌ ±0 
882 runs  +6  882 ✔️ +6  0 💤 ±0  0 ❌ ±0 

Results for commit fc33c22. ± Comparison against base commit fe7a18e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants