Skip to content

Conversation

palbizu
Copy link
Contributor

@palbizu palbizu commented Mar 10, 2021

Description

Icon support was added for toggle groups, keeping support for labels.

Testing

Visual Testing

image

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@palbizu palbizu requested a review from a team as a code owner March 10, 2021 15:56
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #677 (79efd34) into main (fc33c22) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #677   +/-   ##
=======================================
  Coverage   85.22%   85.22%           
=======================================
  Files         780      780           
  Lines       16052    16054    +2     
  Branches     2070     2070           
=======================================
+ Hits        13680    13682    +2     
  Misses       2337     2337           
  Partials       35       35           
Impacted Files Coverage Δ
...ponents/src/toggle-group/toggle-group.component.ts 89.74% <ø> (ø)
...components/src/toggle-group/toggle-group.module.ts 100.00% <100.00%> (ø)
...mponents/src/toggle-group/toggle-item.component.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc33c22...79efd34. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@palbizu palbizu merged commit 0234ae5 into main Mar 10, 2021
@palbizu palbizu deleted the ToggleGroupIconSupport branch March 10, 2021 17:11
@github-actions
Copy link

Unit Test Results

    4 files  ±0  244 suites  ±0   15m 58s ⏱️ + 1m 24s
878 tests ±0  878 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
882 runs  ±0  882 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0234ae5. ± Comparison against base commit fc33c22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants