feat: add large short modal size and fix cloud colors #680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #680 +/- ##
=======================================
Coverage 85.22% 85.22%
=======================================
Files 780 780
Lines 16056 16056
Branches 2071 2071
=======================================
Hits 13684 13684
Misses 2337 2337
Partials 35 35
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
aaron-steinfeld
approved these changes
Mar 10, 2021
| export const enum ModalSize { | ||
| Small = 'small', | ||
| Medium = 'medium', | ||
| LargeShort = 'large-short', |
There was a problem hiding this comment.
hah... I don't get why we bother
There was a problem hiding this comment.
Yeah...
I almost think we should have size enum inputs for height and width. Then we can just mix and match. It will keep us semi-consistent at least.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New modal size for LargeShort.