Skip to content

Conversation

arjunlalb
Copy link
Contributor

Description

Remove host max width for select component.
Containers of the component should be able to control the width.

@arjunlalb arjunlalb requested a review from a team as a code owner March 11, 2021 10:15
@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #684 (c4a5958) into main (4a46f6b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #684   +/-   ##
=======================================
  Coverage   85.18%   85.18%           
=======================================
  Files         782      782           
  Lines       16076    16076           
  Branches     2071     2071           
=======================================
  Hits        13694    13694           
  Misses       2347     2347           
  Partials       35       35           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a46f6b...c4a5958. Read the comment docs.

@github-actions

This comment has been minimized.

Copy link
Contributor

@aaron-steinfeld aaron-steinfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with this change, please check select usages before merging though.

@arjunlalb arjunlalb merged commit 26e9255 into main Mar 11, 2021
@arjunlalb arjunlalb deleted the select-max-width-fix branch March 11, 2021 15:08
@github-actions
Copy link

Unit Test Results

    4 files  ±0  244 suites  ±0   15m 53s ⏱️ +37s
878 tests ±0  878 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
882 runs  ±0  882 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 26e9255. ± Comparison against base commit 4a46f6b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants