fix: remove redundant string formatter methods #703
Conversation
Codecov Report
@@ Coverage Diff @@
## main #703 +/- ##
==========================================
- Coverage 85.16% 85.15% -0.01%
==========================================
Files 782 782
Lines 16042 16036 -6
Branches 2048 2046 -2
==========================================
- Hits 13662 13656 -6
Misses 2347 2347
Partials 33 33
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| .join(' '); | ||
| export const titleCaseFromKebabCase = (kebabCaseString: string): string => titleCaseFromString(kebabCaseString, '-'); | ||
|
|
||
| export const titleCaseFromWhiteSpacedString = (whiteSpacedString: string): string => |
There was a problem hiding this comment.
Is this method similar to Lodash's 'startCase' ?
There was a problem hiding this comment.
Do we still need this new method? 🙂
There was a problem hiding this comment.
startCase works for the other cases for which we've defined util methods as well (kebab/snake case to title case). Going by that, my understanding was that if its light enough, we'll define our own?
There was a problem hiding this comment.
Going by that, my understanding was that if its light enough, we'll define our own?
I think that goes more for components (as the styling on these evolves) or for util function that we'd need to bring in a new dependency for (such as the whole iso duration thing). If we had no lodash dependency, we shouldn't bring it in for this - but since we do have it and it's already in widespread use, we should be ok to use it where it does exactly what we want.
They might have been written without knowing about start case - or maybe they behave a little differently? If the behavior is identical, then we need not implement it ourselves - although we likely leave the existing ones here for backwards compatibility (could deprecate them, though)
There was a problem hiding this comment.
I would vote for deprecating them if they are exactly the same.
There was a problem hiding this comment.
I'd also prefer deprecating them then. startCase works for whitespaced, kebab case and snake cased strings.
arjunlalb
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Description
Remove redundant string formatter methods. Usages to be replaced with startCase in lodash.
Testing
N/A
Checklist: