Skip to content

Conversation

anandtiwary
Copy link
Contributor

@anandtiwary anandtiwary commented Mar 19, 2021

Description

Please include a summary of the change, motivation and context.
refactor: update label detail style

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #708 (5c4b015) into main (008c492) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #708   +/-   ##
=======================================
  Coverage   85.34%   85.34%           
=======================================
  Files         788      788           
  Lines       16129    16129           
  Branches     2055     2055           
=======================================
  Hits        13765    13765           
  Misses       2333     2333           
  Partials       31       31           
Impacted Files Coverage Δ
.../components/label-detail/label-detail.component.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 008c492...5c4b015. Read the comment docs.

@github-actions

This comment has been minimized.

@anandtiwary anandtiwary marked this pull request as ready for review April 7, 2021 23:14
@anandtiwary anandtiwary requested a review from a team as a code owner April 7, 2021 23:14
@github-actions

This comment has been minimized.

@anandtiwary anandtiwary merged commit b91db01 into main Apr 8, 2021
@anandtiwary anandtiwary deleted the update-label-detail-style branch April 8, 2021 00:23
@github-actions
Copy link

github-actions bot commented Apr 8, 2021

Unit Test Results

    4 files  ±0  247 suites  ±0   15m 19s ⏱️ +13s
884 tests ±0  884 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
890 runs  ±0  890 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit b91db01. ± Comparison against base commit 008c492.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants