Summary list clickable #717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #717 +/- ##
==========================================
- Coverage 85.17% 85.16% -0.02%
==========================================
Files 784 784
Lines 16057 16066 +9
Branches 2047 1997 -50
==========================================
+ Hits 13677 13682 +5
- Misses 2347 2351 +4
Partials 33 33
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| class="summary-value" | ||
| [class.clickable]="item.clickable" | ||
| *ngFor="let value of this.getValuesArray(item.value)" | ||
| (click)="this.itemClick.emit(item)" |
There was a problem hiding this comment.
Should not emit if not clickable
This comment has been minimized.
This comment has been minimized.
aaron-steinfeld
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added styling and @output for summary list values that are clickable.
Also added configurable searchPlaceholder to table controls.