Skip to content

Conversation

arjunlalb
Copy link
Contributor

Description

display exit calls breakup in span detail

TODO: Add tests after verifying e2e.

Testing

Manually verified. UTs.
Screenshot 2021-03-27 at 6 08 42 PM

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@arjunlalb arjunlalb requested a review from a team as a code owner March 27, 2021 12:45
@arjunlalb arjunlalb marked this pull request as draft March 27, 2021 12:45
@codecov
Copy link

codecov bot commented Mar 27, 2021

Codecov Report

Merging #724 (2268f38) into main (2ff545a) will increase coverage by 0.03%.
The diff coverage is 95.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #724      +/-   ##
==========================================
+ Coverage   85.16%   85.20%   +0.03%     
==========================================
  Files         784      786       +2     
  Lines       16074    16095      +21     
  Branches     2000     2003       +3     
==========================================
+ Hits        13690    13713      +23     
+ Misses       2351     2349       -2     
  Partials       33       33              
Impacted Files Coverage Δ
...pan-detail/exit-calls/span-exit-calls.component.ts 92.85% <92.85%> (ø)
...s/span-detail/exit-calls/span-exit-calls.module.ts 100.00% <100.00%> (ø)
...ed/components/span-detail/span-detail.component.ts 100.00% <100.00%> (ø)
...hared/components/span-detail/span-detail.module.ts 100.00% <100.00%> (ø)
...-detail/data/api-trace-detail-data-source.model.ts 100.00% <100.00%> (ø)
...components/src/table/data/table-cdk-data-source.ts 83.96% <0.00%> (+0.76%) ⬆️
...ble/cells/data-parsers/table-cell-string-parser.ts 85.71% <0.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ff545a...2268f38. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@arjunlalb arjunlalb marked this pull request as ready for review March 29, 2021 10:07
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@arjunlalb arjunlalb merged commit 31c3be2 into main Mar 29, 2021
@arjunlalb arjunlalb deleted the exit-calls-breakup branch March 29, 2021 12:11
@github-actions
Copy link

Unit Test Results

    4 files  246 suites   14m 47s ⏱️
883 tests 883 ✔️ 0 💤 0 ❌
887 runs  887 ✔️ 0 💤 0 ❌

Results for commit 31c3be2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants