-
Notifications
You must be signed in to change notification settings - Fork 11
fix: updating checkbox component in multi-select #730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #730 +/- ##
=======================================
Coverage 85.20% 85.20%
=======================================
Files 786 786
Lines 16095 16096 +1
Branches 2003 2003
=======================================
+ Hits 13713 13714 +1
Misses 2349 2349
Partials 33 33
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
projects/components/src/multi-select/multi-select.component.test.ts
Outdated
Show resolved
Hide resolved
projects/components/src/multi-select/multi-select.component.test.ts
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
projects/components/src/multi-select/multi-select.component.test.ts
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
projects/components/src/multi-select/multi-select.component.test.ts
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm; will let anand take a look and see if he has any other ideas
Unit Test Results 4 files 246 suites 15m 54s ⏱️ Results for commit 2f3f763. |
Description
The checkbox used within the multi-select component was replaced by the component belonging to the library and also some minor styles were modified.
Testing
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.