Skip to content

Conversation

palbizu
Copy link
Contributor

@palbizu palbizu commented Mar 29, 2021

Description

The checkbox used within the multi-select component was replaced by the component belonging to the library and also some minor styles were modified.

Testing

  • Visual test

image

image

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@palbizu palbizu requested a review from a team March 29, 2021 19:56
@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #730 (6432432) into main (72e5b49) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #730   +/-   ##
=======================================
  Coverage   85.20%   85.20%           
=======================================
  Files         786      786           
  Lines       16095    16096    +1     
  Branches     2003     2003           
=======================================
+ Hits        13713    13714    +1     
  Misses       2349     2349           
  Partials       33       33           
Impacted Files Coverage Δ
...ponents/src/multi-select/multi-select.component.ts 98.43% <ø> (ø)
...components/src/multi-select/multi-select.module.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72e5b49...6432432. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@palbizu palbizu requested a review from anandtiwary March 29, 2021 23:29
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@palbizu palbizu requested a review from anandtiwary March 30, 2021 14:30
Copy link
Contributor

@aaron-steinfeld aaron-steinfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; will let anand take a look and see if he has any other ideas

@palbizu palbizu merged commit 2f3f763 into main Mar 30, 2021
@palbizu palbizu deleted the UpdateCheckboxInMultiSelect branch March 30, 2021 15:23
@github-actions
Copy link

Unit Test Results

    4 files  246 suites   15m 54s ⏱️
883 tests 883 ✔️ 0 💤 0 ❌
887 runs  887 ✔️ 0 💤 0 ❌

Results for commit 2f3f763.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants